Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaybeProtectedForm to optionally skip turnstile #818

Merged
merged 1 commit into from
May 27, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented May 24, 2024

Using <svelte:component> for this purpose caused a warning about an unknown turnstileToken property when the component was Form rather than ProtectedForm. To avoid this warning, we create a new component that selects between Form and ProtectedForm, and sends turnstileToken only to ProtectedForm.

Fixes #816.

Using `<svelte:component>` for this purpose caused a warning about an
unknown `turnstileToken` property when the component was Form rather
than ProtectedForm. To avoid this warning, we create a new component
that selects between Form and ProtectedForm, and sends turnstileToken
only to ProtectedForm.
@rmunn rmunn self-assigned this May 24, 2024
@rmunn rmunn requested a review from myieye May 24, 2024 06:02
Copy link

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 43ae707. ± Comparison against base commit 5c40148.

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@rmunn rmunn merged commit 774f253 into develop May 27, 2024
9 checks passed
@myieye myieye deleted the feat/maybe-protected-form branch January 14, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning in dev about missing turnstile property on CreateUserDialog
3 participants