Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Chorus version #833

Merged
merged 1 commit into from
May 29, 2024
Merged

Bump Chorus version #833

merged 1 commit into from
May 29, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented May 29, 2024

I'm somewhat confused.
This new version of Chorus ensures that hg.exe and not hg is run on Windows.
But now when I build, I don't even have an hg. I'm not sure how I get into the different states.

So, I can't really test this. I just know that I had to manually rename hg.exe to hg several times to be able to run integration tests 😆

Copy link

C# Unit Tests

57 tests  ±0   57 ✅ ±0   9s ⏱️ -1s
11 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit 6ff6918. ± Comparison against base commit 8c03571.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way you will end up with a hg is if you build/restore dotnet in linux, then you will probably have both. I just did this:

  1. locally build dotnet,
  2. in wsl build dotnet
  3. go back to windows and build again
  4. now there's both hg and hg.exe in the mercurial folder under bin.
  5. run dotnet test --filter VerifyHgWorking test passes, where as before it would fail.

@hahn-kev hahn-kev merged commit 3c62210 into develop May 29, 2024
8 checks passed
@hahn-kev hahn-kev deleted the chore/update-chorus branch July 8, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants