-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Playwright and dotnet tests in parallel in CI #856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this to actually use 2 jobs, instead of abusing the matrix to define 2 jobs in one job.
80d7375
to
da47b39
Compare
da47b39
to
74c8b75
Compare
It's test failures when we need this step the most, in fact.
If we do it in a final job, we'd have to use upload-artifact and download-artifact to transfer the files between jobs. Simpler to just run the testspace upload step twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple little things 🙂
We've switched the Testing.csproj to build Mercurial 6 as default, it's time to switch the CI test to run Mercurial 6 by default as well.
# Conflicts: # .github/workflows/integration-test.yaml
Requested changes completed, Kevin is busy with other things so I'm not going to ask him for re-review just now
From my testing, this seems to be working:
The results in Testspace confuse me a bit, but...they're there? https://sillsdev.testspace.com/spaces/275968/metrics |
It looks like there's some kind of bug in test space causing it to lose the os name on the matrix folder for dotnet tests, not sure what's going on there. Tim the dotnet only run seems to have given up, can you make an issue for that? |
I've seen the dotnet test run hang on the self-hosted test runner, usually during the |
Fixes #831.
I haven't removed the "Run Playwright tests" checkbox yet because it's still used in release-pipeline.yaml. Once we decide to get rid of Mercurial 3 and 6 testing and only run tests on Mercurial 6, then that will also be the time to get rid of the "Run Playwright tests" checkbox as it will no longer have a use.