Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Playwright and dotnet tests in parallel in CI #856

Merged
merged 10 commits into from
Jun 17, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Jun 5, 2024

Fixes #831.

I haven't removed the "Run Playwright tests" checkbox yet because it's still used in release-pipeline.yaml. Once we decide to get rid of Mercurial 3 and 6 testing and only run tests on Mercurial 6, then that will also be the time to get rid of the "Run Playwright tests" checkbox as it will no longer have a use.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this to actually use 2 jobs, instead of abusing the matrix to define 2 jobs in one job.

.github/workflows/integration-test.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yaml Outdated Show resolved Hide resolved
@rmunn rmunn force-pushed the chore/parallel-ci-tests branch from 80d7375 to da47b39 Compare June 12, 2024 08:14
It's test failures when we need this step the most, in fact.
If we do it in a final job, we'd have to use upload-artifact and
download-artifact to transfer the files between jobs. Simpler to just
run the testspace upload step twice.
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little things 🙂

.github/workflows/integration-test.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-test.yaml Outdated Show resolved Hide resolved
We've switched the Testing.csproj to build Mercurial 6 as default, it's
time to switch the CI test to run Mercurial 6 by default as well.
# Conflicts:
#	.github/workflows/integration-test.yaml
@rmunn rmunn requested a review from myieye June 14, 2024 08:18
@rmunn rmunn dismissed hahn-kev’s stale review June 14, 2024 08:19

Requested changes completed, Kevin is busy with other things so I'm not going to ask him for re-review just now

@myieye
Copy link
Contributor

myieye commented Jun 14, 2024

From my testing, this seems to be working:

The results in Testspace confuse me a bit, but...they're there? https://sillsdev.testspace.com/spaces/275968/metrics

@hahn-kev
Copy link
Collaborator

hahn-kev commented Jun 14, 2024

It looks like there's some kind of bug in test space causing it to lose the os name on the matrix folder for dotnet tests, not sure what's going on there.

Tim the dotnet only run seems to have given up, can you make an issue for that?

@rmunn
Copy link
Contributor Author

rmunn commented Jun 17, 2024

I've seen the dotnet test run hang on the self-hosted test runner, usually during the dotnet restore step. Seems to happen maybe one time out of three? Often enough that I end up half-expecting it, anyway. Haven't seen that happen on the GitHub-hosted runners. I have seen similar behavior running dotnet restore locally when my VPN connection to Dallas is up and active, so I'm inclined to think that there's a network issue in Dallas that's causing this. At any rate, I don't think it's something that can be solved with a test configuration change, so I'm going to go ahead and merge this.

@rmunn rmunn merged commit 69e07a2 into develop Jun 17, 2024
3 checks passed
@myieye myieye deleted the chore/parallel-ci-tests branch January 14, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider running playwright and dotnet integration tests in parrallel
3 participants