-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show draft projects on users home page #872
Conversation
C# Unit Tests52 tests 52 ✅ 5s ⏱️ Results for commit 04bdab7. ♻️ This comment has been updated with latest results. |
In the list view, we currently display five columns: Name, Code, Users, Last Change, and Type. Given that the 'Last Change' and 'Users' columns are not very descriptive for draft projects, we are leaving them blank for now. Should we consider adding a 'Requested Date/Time' column to provide more relevant information for draft projects? |
Per in-office conversation, we don't want to change the column names/types. We do want to utilize the blank space in the last change column to display some text "awaiting approval". This isn't ideal, but this satisfied the requirement to clearly mark the project as requested/awaiting approval. |
@psh0078 if you could add a screenshot to this PR of the latest version of both the list view and the grid view, that would be great! |
1e967bb
to
da05bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psh0078 Nice work here 🙂 👍
I've got a decent handful of small requests.
Also, our mobile view had been suffering for a while and the large badge in this PR made that more obvious, so I pushed a commit to improve that, which also required me to make a few small changes to the html.
So, make sure you have my commit, before you start making the changes I requested.
|
@psh0078 looks great! I think you just need to make the icon yellow and then this is ready to merge (I think the screenshot is a bit of a lie right? In the screenshot the icon is yellow/warning, but in the code I think it's still blue/primary 😆) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 🚀
Nice work! Just waiting on @hahn-kev to re-review / approve. |
I don't think it's strictly necessary to wait for @hahn-kev's review. He only had a single change request and we don't have a "needs two approvals" policy. |
Fixed. Tim suggested go ahead and merge it
This PR implements the feature to show draft projects on user's home page. It includes the CSS modifications to visually distinguish draft projects.
Will fix #864.
Changes I @psh0078 made in the codebase to implement the feature (show draft projects on users home page):
backend/LexBoxApi/GraphQL/LexQueries.cs
, integrating the MyDraftProjects field into the Query type definition infrontend/schema.graphql
.frontend/src/routes/(authenticated)/+page.ts
.frontend/src/routes/(authenticated)/+page.svelte
file to handle both regular and draft projects under a unified allProjects variable. To do this, adjustments were made to ProjectList.svelte; previously, it accepted projects of type ProjectItem, which couldn't accommodate draft projects. The code was modified to accept ProjectItemWithDraftStatus instead.CSS for draft projects: