Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fwddata bridge Semantic domains and Parts of speech #886

Merged
merged 38 commits into from
Jul 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3e1cd70
define parts of speech models in MiniLcm, implement tests and updates…
hahn-kev Jun 12, 2024
a74c983
remove duplicate field, fix overloaded GetEntries function causing bu…
hahn-kev Jun 14, 2024
e5e339a
add WritingSystemTests.cs, and make the project loader fixture a coll…
hahn-kev Jun 14, 2024
1921a1b
reduce allocations in ContributeExemplars by ~50% by using spans of c…
hahn-kev Jun 14, 2024
d3b25f2
use string contains with StringComparison instead of calling ToLowerI…
hahn-kev Jun 14, 2024
c351dcd
optimize ws lookup when populating exemplars by using a frozen dictio…
hahn-kev Jun 14, 2024
8ebf4f9
Populate UI with parts-of-speech
myieye Jun 18, 2024
2a7692b
Search improvements
myieye Jun 18, 2024
614dbd5
Index dictionary by first grapheme instead of first char
myieye Jun 20, 2024
dcf1970
Revert "Index dictionary by first grapheme instead of first char", be…
myieye Jun 20, 2024
ce8a06d
Fix exemplar lookup not always working
myieye Jun 20, 2024
cfebb61
Add loading indicators
myieye Jun 20, 2024
66504ac
Improve index character overlay size
myieye Jun 20, 2024
07794fb
Option type cleanup
myieye Jun 20, 2024
9834ea5
Add Sandbox to reproduce open bug
myieye Jun 20, 2024
abb1bac
Populate semantic domain dropdown (WIP)
myieye Jun 20, 2024
ddc08c8
Make entry list always fully visible.
myieye Jun 20, 2024
9e3f96c
Prevent unnecessary change events
myieye Jun 20, 2024
97cefeb
Fix type error
myieye Jun 20, 2024
9eba512
Use less peculiar icon
myieye Jun 20, 2024
ef7d13d
Display search keyboard shortcut
myieye Jun 20, 2024
ad568a2
Redesign home page
myieye Jun 20, 2024
e6e5572
Resize keys
myieye Jun 20, 2024
834925f
Fix Part of speech changes not being persisted
myieye Jun 21, 2024
08727e9
Uppercase index exemplars to prevent duplicates
myieye Jun 21, 2024
a9667a5
Store selected-entry, selected-index-char and search in URL
myieye Jun 21, 2024
1804a40
Add transition so increased debounce is not so noticeable.
myieye Jun 21, 2024
9a15ec6
Add save status indicator
myieye Jun 21, 2024
86af499
Layout and mobile fixes
myieye Jun 21, 2024
487d5ef
Cheap fix for semantic domain list being way to big
myieye Jun 21, 2024
f376895
Format selected semantic domains
myieye Jun 21, 2024
db913e8
gracefully handle null order by text
hahn-kev Jul 1, 2024
23add28
rework CrdtMultiOptionField to support editing object lists
hahn-kev Jul 1, 2024
4834db7
add parts of speech to CrdtLexboxApi.cs to fix failing tests
hahn-kev Jul 1, 2024
6506b4e
add parts of speech and semantic domains to the lf classic api
hahn-kev Jul 2, 2024
e75d5a0
disable server garbage collection to reduce memory usage. Disable sin…
hahn-kev Jul 2, 2024
c80bd6b
apply some suggested feedback from review.
hahn-kev Jul 4, 2024
169bad2
normalize exemplar to NFD before using it for comparison
hahn-kev Jul 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add transition so increased debounce is not so noticeable.
myieye committed Jun 21, 2024
commit 1804a406cb3620c615ac0ee3b630fc26fe5d7878
4 changes: 2 additions & 2 deletions frontend/viewer/src/ProjectView.svelte
Original file line number Diff line number Diff line change
@@ -197,7 +197,7 @@
if (!editorElem) return;
const availableHeight = getAvailableHeightForElement(editorElem);
spaceForEditorStyle = `--space-for-editor: ${availableHeight}px`;
}, 15).debounce;
}, 30).debounce;

$: editorElem && updateSpaceForEditor();
onMount(() => {
@@ -256,7 +256,7 @@
class="grid flex-grow items-start justify-stretch md:justify-center"
style="grid-template-columns: minmax(0, min-content) minmax(0, min-content) minmax(0, min-content);"
>
<div class="w-screen max-w-full md:w-[500px] md:min-w-[300px] collapsible-col side-scroller" class:md:!w-[1024px]={expandList} class:md:max-w-[25vw]={!expandList} class:max-md:collapse-col={pickedEntry}>
<div class="w-screen max-w-full md:w-[500px] md:min-w-[300px] collapsible-col side-scroller flex" class:md:!w-[1024px]={expandList} class:md:max-w-[25vw]={!expandList} class:max-md:collapse-col={pickedEntry}>
<EntryList bind:search={$search} entries={$entries} loading={$loadingEntries} bind:expand={expandList} on:entrySelected={() => pickedEntry = true} />
</div>
<div class="max-w-full w-screen md:w-screen collapsible-col" class:md:px-6={!expandList} class:max-md:pr-6={pickedEntry && !$viewConfig.readonly} class:md:collapse-col={expandList} class:max-md:collapse-col={!pickedEntry}>
13 changes: 7 additions & 6 deletions frontend/viewer/src/app.postcss
Original file line number Diff line number Diff line change
@@ -42,17 +42,18 @@
grid-template-columns: 170px fit-content(80px) 1fr;
}

.side-scroller {
max-height: calc(var(--space-for-editor, 100vh) - 32px);
position: sticky;
top: 16px;
}

.collapsible-col {
overflow-x: hidden;
transition: opacity 0.2s ease-out;
}

.side-scroller {
height: calc(var(--space-for-editor, 100vh) - 32px);
transition: height 0.1s ease-out, opacity 0.2s ease-out;
position: sticky;
top: 16px;
}

.collapsible-col.collapse-col {
max-height: 0 !important;
width: 0 !important;
2 changes: 1 addition & 1 deletion frontend/viewer/src/lib/layout/EntryList.svelte
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@
const selectedCharacter = getContext<Writable<string | undefined>>('selectedIndexExamplar');
</script>

<div class="entry-list flex flex-col gap-4 w-full justify-self-center side-scroller">
<div class="entry-list flex flex-col gap-4 w-full justify-self-center">
<div class="flex gap-3 w-full self-center">
<IndexCharacters />
<div class="grow">
Loading