Org managers have full access to projects owned by their org #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 06311c7 contains an attempt to get the JWT
if (User.Orgs.Any(o => o.OrgId == orgId && o.Role == OrgRole.Admin)) return true;The LexAuthUser.GetClaims() method in the backend is seeing the string "Admin" instead of the number 1 that it expects, and so it's turning that role into OrgRole.Unknown. I don't know how to solve that second problem. @hahn-kev, any ideas? Update: Thanks, solved now. |
rmunn
commented
Jul 4, 2024
rmunn
force-pushed
the
feat/org-managers-have-full-access
branch
from
3909e11 to
2dd4fb9
Compare
Org managers can view, edit, and sync any projects owned by the org they manage, even if they themselves are not explicitly listed as a member of that project. This is similar to how site admins have full access to anything, except restricted to projects owned by the org(s) in question.
This should be reverted once the JWTs are being serialized correctly (proper camelCase prop names and enums as strings instead of numbers) in the .NET backend code.
…ather than returning early.
If they turn out to be useful elsewhere, we'll make them public and add then to IPermissionService at that time.
rmunn
force-pushed
the
feat/org-managers-have-full-access
branch
from
2dd4fb9 to
3390063
Compare
C# Unit Tests52 tests 52 ✅ 6s ⏱️ Results for commit 086173b. ♻️ This comment has been updated with latest results. |
First step is to teach integration fixture how to create confidential projects.
Now we're ready to test Send/Receive of confidential projects by an org manager who's not explicitly listed as a project member.
hahn-kev
requested changes
Jul 8, 2024
This will greatly reduce the number of lookups that need to be made when an organization manager are trying to manage a project that he's not an explicit member of.
rmunn
force-pushed
the
feat/org-managers-have-full-access
branch
from
3fe6cf5 to
08bc5f8
Compare
hahn-kev
requested changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915.
This PR used to be on top of #888, but now that #888 is merged, I've rebased on top of develop. So now it's ready to merge once it's been reviewed and approved.