Fix undo problem when lowercase matching is used #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undo was not working when an uppercase word used a guess for the lowercase word. The undo change was getting added for the lowercase word. This pr fixes the problem by adding a undo change for the uppercase word. https://jira.sil.org/browse/LT-21424
|
Decided to close this PR after discussion with Jason. Looking for a different solution that doesn’t add another change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo was not working when an uppercase word used a guess for the lowercase word. The undo change was getting added for the lowercase word. This pr fixes the problem by adding a undo change for the uppercase word.
https://jira.sil.org/browse/LT-21424
This change is