-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LT-21899: Parse Prioritizer look at following word as well as preceding word #315
Conversation
The code in this method looks suspicious. I'm not sure how only checking the previousWordForm could be correct. I still have more code to read, but this has me scratching my head at the moment. |
The code is actually correct, although it does look suspicious. I will fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
I added code that gathers statistics about how often each approved analysis occurs in the context of a previous word and in the context of a following word. This is used by GetContextScore in ComparePriorityCounts to order the analyses for a particular occurrence.
This change is