Upgraded SIL.BuildTasks used in .proj file. Removed dependency on it from SIL.Windows.Forms

[tombogle]

This change is 

[github-actions]

LibPalaso Tests

    36 files   -     9      36 suites   - 9   8m 47s ⏱️ - 3m 8s
 4 132 tests  -   698   3 906 ✅  -   693  225 💤  -  6  1 ❌ +1 
11 152 runs   - 2 856  10 595 ✅  - 2 786  556 💤  - 71  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 75bb705. ± Comparison against base commit de37405.

This pull request removes 698 tests.

SIL.DblBundle.Tests.BundleTests ‑ LanguageIso_LanguageCodeSpecifiedInMetadata_ReturnsLanguageCode
SIL.DblBundle.Tests.BundleTests ‑ LanguageIso_NoLanguageCodeSpecified_ReturnsCodeForUnlistedLanguage
SIL.DblBundle.Tests.DblMetadataCopyrightTests ‑ ConstructorFromString_SimpleString_StatementHasSingleNode
SIL.DblBundle.Tests.DblMetadataCopyrightTests ‑ ConstructorFromString_XHtmlStringWithTwoParagraphs_StatementHasTwoNodesWithCorrectContent
SIL.DblBundle.Tests.DblMetadataCopyrightTests ‑ ToString_AsXHtml_ResultIsStatementXhtml
SIL.DblBundle.Tests.DblMetadataCopyrightTests ‑ ToString_SeparatorSpecified_SpecifiedSeparatorUsed
SIL.DblBundle.Tests.DblMetadataTests ‑ GetCopyrightStatement
SIL.DblBundle.Tests.DblMetadataTests ‑ GetDateArchived
SIL.DblBundle.Tests.DblMetadataTests ‑ GetId
SIL.DblBundle.Tests.DblMetadataTests ‑ GetLanguageIso
…

[josephmyers]

I see a single failing test here that I haven't seen be flaky before. Have you looked into this? I wonder if that would alleviate the problem of all the missing tests.

[andrew-polk]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

[tombogle]

I see a single failing test here that I haven't seen be flaky before. Have you looked into this? I wonder if that would alleviate the problem of all the missing tests.

I didn't even bother looking. I figured I'd wait until the flaky test issue was resolved for good first.

[josephmyers]

We can hope it gets fixed, but we're still seeing flaky tests, even when running each framework on its own machine. At the very least, my PR reduces server build time. It should also help with flakiness, but it won't go away. Some of these tests are just inherently flaky, unrelated to framework, e.g. testing the clipboard. In their case, we just need to mark them with Retry. I've done this for the one I'm seeing on my PR, but it'll be case by case, whether we can improve it or have to mark it with Retry.

[github-actions]

Palaso Tests

     3 files  ±    0       3 suites  ±0   17m 17s ⏱️ + 8m 55s
 4 837 tests ±    0   4 606 ✅ ±    0  231 💤 ±  0  0 ❌ ±0 
14 022 runs  +4 778  13 395 ✅ +4 500  627 💤 +278  0 ❌ ±0 

Results for commit 3aaa08d. ± Comparison against base commit 7d09928.

♻️ This comment has been updated with latest results.

[tombogle]

We can hope it gets fixed, but we're still seeing flaky tests, even when running each framework on its own machine. At the very least, my PR reduces server build time. It should also help with flakiness, but it won't go away. Some of these tests are just inherently flaky, unrelated to framework, e.g. testing the clipboard. In their case, we just need to mark them with Retry. I've done this for the one I'm seeing on my PR, but it'll be case by case, whether we can improve it or have to mark it with Retry.

Neither this text DLL nor the SUT reference SIL.BuildTasks, and this test passes for me locally, so it feels unlikely that it could be caused by this change. I did a tiny code simplification. Let's see if it magically passes this time.

[tombogle]

After merging master, all the tests pass. However, I'm also seeing a similar failure in #1364, so I suspect it is another instance of flakiness. Not 100% sure, but it seems to be coming from tests of LocateInProgramFilesFolder. I would think that if we're running up against a permissions problem, it would be failing consistently. But those tests do seem at least somewhat susceptible to failures on build agents.