-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made FadingMessageWindow implement all UI logic on the UI thread #1375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, though the popup message was not relative to the test app form which was surprising.
Yeah, I probably could have (and maybe should have) gotten it to pop up in a more sensible place, but for the test app I didn't care. I just wanted to make sure it appeared and faded as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @hahn-kev and @josephmyers)
bed9607
to
1f7f59a
Compare
This fixes crashes like SP-2340
I have marked this as a breaking change because of the removal of protected members, but I know of no derived classes, and in practice, the existing implementation was such that these members would be unlikely to have been meaningful or helpful in a derived class anyway.
This change is