Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripture range parser no error on empty string #110

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jul 12, 2024

Fixes sillsdev/serval#395

Parallel PR: sillsdev/machine#226


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (9a0b3fc) to head (aea0368).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         243      243           
  Lines       14238    14239    +1     
=======================================
+ Hits        12526    12527    +1     
  Misses       1712     1712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 7d85f16 into main Jul 16, 2024
14 checks passed
@johnml1135 johnml1135 deleted the scripture_range_parser_no_error_on_empty_string branch July 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptureRangeParser shouldn't throw exception when passed an empty string
3 participants