Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word alignment Refinement #151

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Word alignment Refinement #151

merged 3 commits into from
Jan 17, 2025

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Jan 17, 2025

Most of this is John's work. This PR needs to be approved to enable running the E2E tests in Serval.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (6de035f) to head (e862df2).

Files with missing lines Patch % Lines
machine/jobs/word_alignment_file_service.py 57.89% 8 Missing ⚠️
machine/corpora/parallel_text_corpus.py 88.23% 2 Missing ⚠️
machine/jobs/shared_file_service_base.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   88.33%   88.30%   -0.04%     
==========================================
  Files         275      275              
  Lines       16192    16235      +43     
==========================================
+ Hits        14304    14337      +33     
- Misses       1888     1898      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Enkidu93 Enkidu93 force-pushed the word_alignment_refine branch from c956356 to e862df2 Compare January 17, 2025 16:04
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 101d227 into main Jan 17, 2025
14 checks passed
@johnml1135 johnml1135 deleted the word_alignment_refine branch January 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants