Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN alignment score in FuzzyEditDistanceWordAlignmentMethod #146

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Nov 30, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4730114) 66.00% compared to head (f95b68c) 66.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   66.00%   66.00%           
=======================================
  Files         426      426           
  Lines       33074    33074           
  Branches     4441     4441           
=======================================
  Hits        21830    21830           
  Misses      10182    10182           
  Partials     1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

:lgtm:

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit e40bdeb into master Dec 1, 2023
3 checks passed
@ddaspit ddaspit deleted the nan-fuzzy-ed-method branch December 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN alignment score in FuzzyEditDistanceWordAlignmentMethod
3 participants