Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unecessary class from Serval and reworked Machine code using it #148

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Dec 6, 2023

This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit December 6, 2023 19:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7ea2e0) 66.33% compared to head (191369c) 66.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   66.33%   66.33%           
=======================================
  Files         427      427           
  Lines       33256    33256           
  Branches     4463     4463           
=======================================
  Hits        22060    22060           
  Misses      10126    10126           
  Partials     1070     1070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)


src/SIL.Machine.AspNetCore/Usings.cs line 42 at r1 (raw file):

global using SIL.Scripture;
global using SIL.WritingSystems;
global using System.Collections.Concurrent;

It is normal in C# to sort the System usings first.

@Enkidu93
Copy link
Collaborator Author

Enkidu93 commented Dec 6, 2023

src/SIL.Machine.AspNetCore/Usings.cs line 42 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

It is normal in C# to sort the System usings first.

OK! It's funny because I looked at Serval.Translation as an example, and its usings are also purely alphabetical. (I'll go ahead and push a reordering of the usings in serval to main if that's alright). Done.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the remove_custom_json_enum_converter branch from 047f6a5 to 191369c Compare December 6, 2023 22:51
@Enkidu93 Enkidu93 merged commit 6a0e2fb into master Dec 7, 2023
3 checks passed
@Enkidu93 Enkidu93 deleted the remove_custom_json_enum_converter branch December 7, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants