Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detokenizing USFM #154

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add support for detokenizing USFM #154

merged 1 commit into from
Jan 5, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jan 4, 2024


This change is Reviewable

@johnml1135 johnml1135 self-requested a review January 5, 2024 16:10
@johnml1135
Copy link
Collaborator

src/SIL.Machine/Corpora/UsfmToken.cs line 228 at r1 (raw file):

                if (!string.IsNullOrEmpty(Data))
                {
                    if (!addSpaces && (Marker.Length == 0 || Marker[Marker.Length - 1] != '*'))

What does this do?

@johnml1135
Copy link
Collaborator

src/SIL.Machine/Corpora/UsfmToken.cs line 228 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

What does this do?

Ported updates from machine.py.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 6451c71 into master Jan 5, 2024
4 checks passed
@ddaspit ddaspit deleted the detokenize-usfm branch January 5, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for manipulating USFM
2 participants