Drive health

[johnml1135]

Resolves #141 and sillsdev/serval#243.

---

This change is 

[ddaspit]

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @johnml1135)

---

src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs line 224 at r1 (raw file):

    public static IMachineBuilder AddMongoDataAccess(this IMachineBuilder builder, string? connectionString = null)
    {
        connectionString ??= builder.Configuration!.GetConnectionString("Mongo");

Please avoid using the null-forgiving operator when possible. Throw an exception if necessary.

---

src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs line 375 at r1 (raw file):

            string EnginesDir = builder.Configuration
                .GetSection(SmtTransferEngineOptions.Key)!

I don't think that the null-forgiving operators are needed here.

---

src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs line 378 at r1 (raw file):

                .GetValue<string>("EnginesDir")!;

            string driveLetter = Path.GetPathRoot(EnginesDir)![..1];

Please avoid using the null-forgiving operator when possible.

---

src/SIL.Machine.AspNetCore/Services/ClearMLAuthenticationService.cs line 13 at r1 (raw file):

    // to know well ahead of time if something is wrong.
    private static readonly TimeSpan RefreshPeriod = TimeSpan.FromSeconds(3600);
    private string? _authToken = "";

I don't think it is ever possible for _authToken to be null.

[ddaspit]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

[johnml1135]

src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs line 224 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Please avoid using the null-forgiving operator when possible. Throw an exception if necessary.

Does that meet your expectations?

[johnml1135]

src/SIL.Machine.AspNetCore/Configuration/IMachineBuilderExtensions.cs line 378 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Please avoid using the null-forgiving operator when possible.

Fixed.

[johnml1135]

src/SIL.Machine.AspNetCore/Services/ClearMLAuthenticationService.cs line 13 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I don't think it is ever possible for _authToken to be null.

I revised the logic a bit to handle edge cases better. Specifically, if we can't get the auth token when first starting up, we should crash out. If refreshing fails, we should keep laboring on as long as possible.

[ddaspit]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)