Fix terms bugs #208
Merged
Fix terms bugs #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 67.37% 67.35% -0.02%
==========================================
Files 441 441
Lines 35134 35144 +10
Branches 4702 4703 +1
==========================================
Hits 23672 23672
- Misses 10372 10381 +9
- Partials 1090 1091 +1 ☔ View full report in Codecov by Sentry. |
|
I'm not sure of the cleanest way to extend our tests for the case of the nonexistent ProjectBiblicalTerms file. Should I not worry about it or go ahead and create an entire second project to cover the new case? |
Fix error on terms id duplication
johnml1135
force-pushed
the
fix_terms_bugs
branch
from
46912a4 to
2fb3422
Compare
johnml1135
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sillsdev/serval#391
Fixes sillsdev/serval#392
This change is