Clarify and fix logic for textId and Chapters. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 67.23% 67.22% -0.01%
==========================================
Files 441 441
Lines 35277 35281 +4
Branches 4721 4719 -2
==========================================
+ Hits 23717 23718 +1
- Misses 10466 10471 +5
+ Partials 1094 1092 -2 ☔ View full report in Codecov by Sentry. |
ddaspit
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
johnml1135
force-pushed
the
textid_chapters_fix
branch
from
5589371 to
67f63b8
Compare
johnml1135
force-pushed
the
textid_chapters_fix
branch
from
054c9a6 to
e36a889
Compare
ddaspit
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is