Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usfm nonverse multichapter #224

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Usfm nonverse multichapter #224

merged 3 commits into from
Jul 12, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jul 12, 2024

sillsdev/serval#424


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit July 12, 2024 16:02
- Add extra info when exception occurs while tokenizing in UsfmTextBase
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.67%. Comparing base (04276d7) to head (10e0522).

Files Patch % Lines
src/SIL.Machine/Corpora/UsfmTextBase.cs 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   69.65%   69.67%   +0.01%     
==========================================
  Files         374      374              
  Lines       31300    31314      +14     
  Branches     4384     4386       +2     
==========================================
+ Hits        21803    21818      +15     
+ Misses       8479     8478       -1     
  Partials     1018     1018              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 merged commit 2659e19 into master Jul 12, 2024
4 checks passed
@ddaspit ddaspit deleted the usfm_nonverse_multichapter branch July 22, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants