Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assessment #550

Merged
merged 1 commit into from
Dec 3, 2024
Merged

remove assessment #550

merged 1 commit into from
Dec 3, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Dec 2, 2024

We can always add it back.


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit December 2, 2024 18:50
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

Reviewable status: 0 of 51 files reviewed, all discussions resolved (waiting on @ddaspit)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (03e4716) to head (1cb342b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   57.03%   61.03%   +4.00%     
==========================================
  Files         302      270      -32     
  Lines       15639    13544    -2095     
  Branches     2155     1782     -373     
==========================================
- Hits         8919     8267     -652     
+ Misses       6076     4687    -1389     
+ Partials      644      590      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator Author

Damien said to. We are doing WordAlignments rather than Assessments. We can always add Assessments back in if we need to.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 51 files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 3bbda03 into main Dec 3, 2024
2 of 3 checks passed
@johnml1135 johnml1135 deleted the remove_assessment branch December 3, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants