update to 8.0 for e2e tests

[johnml1135]

These fixes are needed to get E2E tests working:

• Update e2e build image to dotnet 8.0
• Fixes for BuildSummary including:
  • Use Protobuf.System.Text.Json to properly format dictionaries: https://stackoverflow.com/questions/66300807/protobuf-map-unserialization-issue
    • Update outbox handling to deal with the new Json Options
  • Fix E2E test properly getting build info after build is complete

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (38e582c) to head (905c95f).

Files with missing lines	Patch %	Lines
...l.Machine.Shared/Services/ServalPlatformService.cs	0.00%	14 Missing ⚠️
...red/Services/ServalPlatformOutboxMessageHandler.cs	30.76%	9 Missing ⚠️
...al.Machine.Shared/Services/MessageOutboxService.cs	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   63.03%   63.14%   +0.11%     
==========================================
  Files         279      279              
  Lines       14042    14071      +29     
  Branches     1817     1816       -1     
==========================================
+ Hits         8851     8885      +34     
+ Misses       4567     4564       -3     
+ Partials      624      622       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Enkidu93]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

[johnml1135]

@Enkidu93 - more changes to get E2E tests to pass...

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Serval.Machine.Shared.csproj line 39 at r2 (raw file):

		<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.8" />
		<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="8.0.8" />
		<PackageReference Include="Protobuf.System.Text.Json" Version="1.4.0" />

The options were either add this package or use Newtonsoft (https://stackoverflow.com/questions/66300807/protobuf-map-unserialization-issue). I really don't care one way or the other. A lot of the other changes were to centralize the JsonSerializationOptions that need to be referenced when both serializing and deserializing (https://github.com/Havret/Protobuf.System.Text.Json).

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxDeliveryService.cs line 107 at r2 (raw file):

        IRepository<OutboxMessage> messages,
        OutboxMessage message,
        string groupId,

Passing the group Id is so that the stream can have the engineId (which is not in the stream itself but is needed). These changes can be reverted, but it makes more logical sense to me to handle content and contentStream in different calls. This also corresponds with the serialization no longer being standard, but needing to have the protobuf support added. It made more logical sense to have that at the MessageOutboxService level rather than the ServalPlatformService level.

[ddaspit]

Reviewed 1 of 1 files at r1, 13 of 13 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/Machine/src/Serval.Machine.Shared/Serval.Machine.Shared.csproj line 39 at r2 (raw file):

Previously, johnml1135 (John Lambert) wrote…

The options were either add this package or use Newtonsoft (https://stackoverflow.com/questions/66300807/protobuf-map-unserialization-issue). I really don't care one way or the other. A lot of the other changes were to centralize the JsonSerializationOptions that need to be referenced when both serializing and deserializing (https://github.com/Havret/Protobuf.System.Text.Json).

I think I would prefer to use Newtonsoft. It is a better tested and more widely used package and we already have a dependency on it.

---

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxDeliveryService.cs line 107 at r2 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Passing the group Id is so that the stream can have the engineId (which is not in the stream itself but is needed). These changes can be reverted, but it makes more logical sense to me to handle content and contentStream in different calls. This also corresponds with the serialization no longer being standard, but needing to have the protobuf support added. It made more logical sense to have that at the MessageOutboxService level rather than the ServalPlatformService level.

These look like good improvements.

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Serval.Machine.Shared.csproj line 39 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I think I would prefer to use Newtonsoft. It is a better tested and more widely used package and we already have a dependency on it.

Newtonsoft appears to be in maintenance mode - it was last released in March '23. Moreover, there is no Sync Deserialize support (nor will there be): https://stackoverflow.com/questions/72451669/deserializing-to-asyncenumerable-using-newtonsoft-json. I am inclined to keep with the newer package instead of writing (or copying) a deserializer in for something that will never be rolled out in the main package.

[ddaspit]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

---

src/Machine/src/Serval.Machine.Shared/Serval.Machine.Shared.csproj line 39 at r2 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Newtonsoft appears to be in maintenance mode - it was last released in March '23. Moreover, there is no Sync Deserialize support (nor will there be): https://stackoverflow.com/questions/72451669/deserializing-to-asyncenumerable-using-newtonsoft-json. I am inclined to keep with the newer package instead of writing (or copying) a deserializer in for something that will never be rolled out in the main package.

No async support is an issue, so I'm good with using the newer package.