-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no pretranslations written #602
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs
line 90 at r1 (raw file):
await contentStream.CopyToAsync(fileStream, cancellationToken); await fileStream.FlushAsync(cancellationToken); await fileStream.DisposeAsync();
Instead of explicitly calling dispose, we should scope the using
block properly.
Previously, ddaspit (Damien Daspit) wrote…
Is that what you were thinking about? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 64.48% 64.48%
=======================================
Files 280 280
Lines 14105 14105
Branches 1825 1823 -2
=======================================
+ Hits 9095 9096 +1
+ Misses 4349 4348 -1
Partials 661 661 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs
line 90 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Is that what you were thinking about?
Yes. It should be an await using
.
Fix for #601 - Make sure you flush!
This change is