fix flaky test

This test asserts that the settingsMenuLink is not present, and the appropriate test should be `isPresent()` not `isDisplayed()`
sillsdev · Mar 10, 2022 · fb2885d · fb2885d
1 parent 8bfaf45
commit fb2885d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/test/app/bellows/project-settings.e2e-spec.ts b/test/app/bellows/project-settings.e2e-spec.ts
@@ -15,7 +15,7 @@ describe('Bellows E2E Project Settings app', () => {
     await loginPage.loginAsMember();
     await projectsPage.get();
     await projectsPage.clickOnProject(constants.testProjectName);
-    expect<boolean>(await settingsPage.settingsMenuLink.isDisplayed()).toBe(false);
+    expect<boolean>(await settingsPage.settingsMenuLink.isPresent()).toBe(false);
   });
 
   it('System Admin can manage project', async () => {

diff --git a/test/app/languageforge/lexicon/settings/config-fields.e2e-spec.ts b/test/app/languageforge/lexicon/settings/config-fields.e2e-spec.ts
@@ -39,7 +39,7 @@ describe('Lexicon E2E Configuration Fields', () => {
   });
 
   it('can go to Configuration and select unified Fields tab', async () => {
-    expect<any>(await configPage.settingsMenuLink.isDisplayed()).toBe(true);
+    expect<any>(await configPage.settingsMenuLink.isPresent()).toBe(true);
     await configPage.get();
     expect<any>(await configPage.applyButton.isDisplayed()).toBe(true);
     expect<any>(await configPage.applyButton.isEnabled()).toBe(false);

diff --git a/test/app/languageforge/lexicon/settings/config-input-systems.e2e-spec.ts b/test/app/languageforge/lexicon/settings/config-input-systems.e2e-spec.ts
@@ -17,14 +17,14 @@ describe('Lexicon E2E Configuration Input Systems', () => {
     await loginPage.loginAsUser();
     await projectsPage.get();
     await projectsPage.clickOnProject(constants.testProjectName);
-    expect<boolean>(await configPage.settingsMenuLink.isDisplayed()).toBe(false);
+    expect<boolean>(await configPage.settingsMenuLink.isPresent()).toBe(false);
   });
 
   it('setup: login as manager, select test project, goto configuration', async () => {
     await loginPage.loginAsManager();
     await projectsPage.get();
     await projectsPage.clickOnProject(constants.testProjectName);
-    expect<any>(await configPage.settingsMenuLink.isDisplayed()).toBe(true);
+    expect<any>(await configPage.settingsMenuLink.isPresent()).toBe(true);
     await configPage.get();
     expect<any>(await configPage.applyButton.isDisplayed()).toBe(true);
     expect<any>(await configPage.applyButton.isEnabled()).toBe(false);