Disable editing input systems #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laineyhm
force-pushed
the
disable-editing-input-systems
branch
from
f89f28a to
4c511d6
Compare
longrunningprocess
approved these changes
Oct 26, 2022
Tests in stagingInput systems tab✅ button gone and instructional text added
Fields tab✅ button gone and instructional text added
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553
Description
Input systems should not be edited in Language Forge, only in FLEx.
In this PR:
-Got rid of the 'three dots menu' that allowed adding input systems, on the "Input Systems" tab in Configuration
-Kept selectors for RTL language, language abbreviation, and font name
-Other settings for writing systems are displayed but not editable (special, purpose, variant, region), with a message to that effect
-Got rid of "+ New" buttons in the input systems tab and under "Input Systems" in the base configuration page
-Got rid of the modal for adding a new writing system, formerly attached to these buttons
Type of Change
Only keep lines below that describe this change, then delete the rest.
Screenshots
Before:
After:
Before:
After:
Checklist
How to test
General smoke test, and:
Navigate to the Configuration page. Ensure that the '+' below the Input Systems is gone and there is a message saying 'To edit input systems, please use Fieldworks (FLEx).'
Navigate to the Input Systems tab of Configuration. Ensure that the three dots menu is gone from the top left-middle of the screen; ensure that the '+ New' button for adding a new input system is gone; ensure that the fields below the message reading 'Some settings are disabled; please edit these in Fieldworks (FLEx)' are disabled and are regular text inputs (not selectors).
qa.languageforge.org testing
Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org