-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utilize more types in LFNext #1664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. The only thing left that we discussed was throw_error
, right now it only accepts a string, but in fetch we're potentially passing it an error object when there's a network error and throw_error
should be updated to indicate that it accepts an Error
object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate you putting the time into this 🤓. I mostly just have a few ideas. Feel free to use or toss whichever you wish.
Co-authored-by: Tim Haasdyk <[email protected]>
Co-authored-by: Tim Haasdyk <[email protected]>
QA 🧪✅ exercise the change password feature We decided that there's nothing critical enough here to stop the release, but there is some work to be done. So, I've created #1690 |
Description
This PR begins to utilize types more extensively in the LFNext app.
Type of Change
Checklist
How to test
qa.languageforge.org testing
Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.