Make project backup script auth-aware #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit e056300. ♻️ This comment has been updated with latest results. |
rmunn
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Sure, that works. I had another solution in my local repo that wasn't as good, and hadn't figured out a better way to do it, so let's go with this instead. In theory this could expose the password (command-line parameters are visible to other processes, at least on Linux) so in theory this should be done with a password-file arg instead (e.g., read the password from the file provided on the command line), but in practice that's not a serious concern as this only gets run on dev machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we added MongoDB auth right after the backup script was created, so it was missing this.