Skip to content

Commit

Permalink
Reconstructing segments when the donut data changes
Browse files Browse the repository at this point in the history
This restores functionality to the donut, which is currently broken on Live. I'm not sure how this was ever working updating the view when the data changes, but my guess is that the callers were destroying and recreating the component whenever the data changed, avoiding this issue. I would imagine it's better practice to not require this.
  • Loading branch information
josephmyers committed Dec 4, 2024
1 parent afcb700 commit 3112354
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export class DonutChartComponent extends SubscriptionDisposable implements After
this.oldData = this._data;
}
this._data = value;
this.constructSegments();
}
}

Expand Down

0 comments on commit 3112354

Please sign in to comment.