SF-2733 Remove old draft preview page #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 77.53% 77.49% -0.04%
==========================================
Files 511 510 -1
Lines 29273 29160 -113
Branches 4779 4737 -42
==========================================
- Hits 22697 22598 -99
- Misses 5819 5823 +4
+ Partials 757 739 -18 ☔ View full report in Codecov by Sentry. |
pmachapman
approved these changes
May 26, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)
pmachapman
force-pushed
the
task/SF-2733-remove-draft-viewer
branch
from
5f9b5ef to
09644cb
Compare
pmachapman
approved these changes
May 26, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the draft viewer component. The draft service component is being used, so that needs to remain in place. This should be confirmed by the reviewer and does not need to go to testers because it does not have a functional side-effect.
This change is