-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell user which books have a draft when viewing chapter with no draft #2484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.html
line 18 at r1 (raw file):
</ng-container> <div class="toolbar" *ngIf="isDraftReady">
Added this check to get rid of this ugly line caused by the toolbar being present despite having no content.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 511 511
Lines 29260 29260
Branches 4753 4775 +22
=======================================
Hits 22687 22687
+ Misses 5829 5817 -12
- Partials 744 756 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Nateowami)
src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json
line 243 at r1 (raw file):
"editor_draft_tab": { "apply_to_project": "Add to project", "click_book_to_preview": "Click a book below to preview the draft and add it to your project.",
I like the clear call-to-action for this message. We could add a link to direct the user to the generate draft page, but definitely does not need to hold up this PR.
Code quote:
"click_book_to_preview": "Click a book below to preview the draft and add it to your project.",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)
src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json
line 243 at r1 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
I like the clear call-to-action for this message. We could add a link to direct the user to the generate draft page, but definitely does not need to hold up this PR.
You can't open the draft tab unless there's a draft, so I think what we have here actually covers the bases.
This change is