Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell user which books have a draft when viewing chapter with no draft #2484

Merged
merged 1 commit into from
May 24, 2024

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented May 24, 2024


This change is Reviewable

Copy link
Collaborator Author

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion


src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.html line 18 at r1 (raw file):

</ng-container>

<div class="toolbar" *ngIf="isDraftReady">

Added this check to get rid of this ugly line caused by the toolbar being present despite having no content.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (5d5aba7) to head (b9bf934).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2484   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         511      511           
  Lines       29260    29260           
  Branches     4753     4775   +22     
=======================================
  Hits        22687    22687           
+ Misses       5829     5817   -12     
- Partials      744      756   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this May 24, 2024
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Nateowami)


src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json line 243 at r1 (raw file):

  "editor_draft_tab": {
    "apply_to_project": "Add to project",
    "click_book_to_preview": "Click a book below to preview the draft and add it to your project.",

I like the clear call-to-action for this message. We could add a link to direct the user to the generate draft page, but definitely does not need to hold up this PR.

Code quote:

    "click_book_to_preview": "Click a book below to preview the draft and add it to your project.",

@Nateowami Nateowami requested a review from RaymondLuong3 May 24, 2024 18:36
Copy link
Collaborator Author

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)


src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json line 243 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

I like the clear call-to-action for this message. We could add a link to direct the user to the generate draft page, but definitely does not need to hold up this PR.

You can't open the draft tab unless there's a draft, so I think what we have here actually covers the bases.

@Nateowami Nateowami merged commit bf01ca9 into master May 24, 2024
15 of 16 checks passed
@Nateowami Nateowami deleted the feature/point-user-to-books-when-no-draft branch May 24, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants