Remove unused private members from TypeScript files #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
- Coverage 79.36% 79.36% -0.01%
==========================================
Files 534 534
Lines 31076 31072 -4
Branches 5062 5045 -17
==========================================
- Hits 24664 24659 -5
- Misses 5622 5634 +12
+ Partials 790 779 -11 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
force-pushed
the
fix/remove-unused-private-members
branch
from
95b0a63 to
c6bb0c6
Compare
RaymondLuong3
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found by temporarily adding
"noUnusedLocals": truetosrc/SIL.XForge.Scripture/ClientApp/tsconfig.json.I did not persist the config change because the FeatureFlagService has private properties that are accessed via
Object.values(this), but appear to not be used when only statically analyzed.This change is