-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF-2392 Add event metric logging #2894
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2894 +/- ##
==========================================
+ Coverage 80.89% 81.97% +1.08%
==========================================
Files 533 545 +12
Lines 31262 31536 +274
Branches 5083 5112 +29
==========================================
+ Hits 25288 25851 +563
+ Misses 5211 4939 -272
+ Partials 763 746 -17 ☔ View full report in Codecov by Sentry. |
1598c55
to
f474dc5
Compare
9042475
to
8c20c54
Compare
90e46eb
to
b6ec6c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain that both the event-metrics.component
and event-metrics-log.component
are necessary. Is there a reason for two separate components for this?
Reviewed 5 of 11 files at r1, 5 of 10 files at r2, 8 of 11 files at r3, 2 of 8 files at r4, 17 of 21 files at r6, all commit messages.
Reviewable status: 37 of 41 files reviewed, 9 unresolved discussions (waiting on @Github-advanced-security[bot] and @pmachapman)
src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts
line 35 at r6 (raw file):
constructor( noticeService: NoticeService, private readonly i18n: I18nService,
Will this be needed since it's an admin only screen?
Code quote:
private readonly i18n: I18nService,
src/SIL.XForge/EventMetrics/EventScope.cs
line 1 at r6 (raw file):
namespace SIL.XForge.EventMetrics;
Should we consider adding Users scope? For SF invites and roles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain that both the
event-metrics.component
andevent-metrics-log.component
are necessary. Is there a reason for two separate components for this?
This PR is still work in progress. I am still writing this (and other) areas of the code.
Dismissed @Github-advanced-security[bot] from 7 discussions.
Reviewable status: 37 of 41 files reviewed, 2 unresolved discussions (waiting on @Github-advanced-security[bot] and @kylebuss)
src/SIL.XForge/EventMetrics/EventScope.cs
line 1 at r6 (raw file):
Previously, kylebuss (Kyle Buss) wrote…
Should we consider adding Users scope? For SF invites and roles?
These can be added if needed.
src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metrics-log.component.ts
line 35 at r6 (raw file):
Previously, kylebuss (Kyle Buss) wrote…
Will this be needed since it's an admin only screen?
Yes, as project admins will access it.
e7f66e8
to
42ab49d
Compare
bb24575
to
78f2718
Compare
Previously, pmachapman (Peter Chapman) wrote…
nit Can the |
3665ea1
to
e0a3927
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r17, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
0af979a
to
875cc5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r18, 6 of 6 files at r19, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
Add unit tests for MongoRepository Fix return value of DeleteAllAsync Change MongoRepository to use primary constructor
57af41d
to
b8749b7
Compare
This PR adds support for logging events via the
[LogEventMetric]
attribute.To access it, a button is added to the serval admin page. Although permissions are granted for project admins to view the event log, a link is not provided in the UI until we are ready to expose it to a wider audience.
This PR is intended to be a minimal MVP leaving enough scope for us to expand in the coming months. Perhaps the bulk of the new code is unit tests for existing functionality that did not have unit tests.
See https://github.com/sillsdev/web-xforge/wiki/Event-Metric-Logging for documentation on how this feature works and how to use it.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)