Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer loading #20

Closed
wants to merge 3 commits into from
Closed

Conversation

hexmode
Copy link

@hexmode hexmode commented Nov 29, 2019

These help with loading.

Tested with technion/maia_mailguard#80

@hexmode hexmode changed the title Composer fixups Composer loading Nov 29, 2019
@gauthierm
Copy link
Member

@hexmode Is the include-path needed? I'd like to keep it out if at all possible.

@hexmode
Copy link
Author

hexmode commented Jan 23, 2020

@hexmode Is the include-path needed? I'd like to keep it out if at all possible.

You could leave it out, but i think i needed it. i'm not sure why right now.

I'll be returning to this, later, though, so I won't have time to test right now.

@gauthierm
Copy link
Member

pear packages expect the php include_path to include where pear packages are installed.

If you're not using pear, this is an anti-feature as the composer autoloader works best and most efficiently when the include path is empty.

@gauthierm
Copy link
Member

I'd like to merge this without the include-path change.

@gauthierm
Copy link
Member

Replaced with #21

Since original author is not responding, closing this PR.

@gauthierm gauthierm closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants