Add chromeOptions only for chrome and change default Capabilities #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GuySartorelli, Can you read my PR to remove my fork and use the original repository? Please. |
|
Sorry, I don't have time to learn how this works right now, and I don't understand it well enough to know what (if any) downstream effects this might have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this extension with Firefox and Safari web browser on Lambdatest service.
Il the
chromeOptionsis defined, only chrome work. In my proposal, I check if thew3coption is defined and add it if not found only for the Chrome browser.In
FacebookWebDriver::getDefaultCapabilitiesfunction the selenium version is defined and device option too. But, I don't want to execute my test on a tablet. And I need to remove their options but I cannot.In fact, these specific options need to be added to the mink configuration on the project.