ENH Add generic types #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jan 23, 2024
| use SilverStripe\Control\Email\Email; | ||
| use SilverStripe\Core\Extension; | ||
| use SilverStripe\Forms\Form; | ||
|
|
||
| /** | ||
| * Customises the comment form to conform to government usability standards | ||
| * | ||
| * {@see CommentingController} | ||
| * @extends DataExtension<CommentingController> |
There was a problem hiding this comment.
Suggested change
| * @extends DataExtension<CommentingController> | |
| * @extends Extension<CommentingController> |
| @@ -16,6 +16,8 @@ | |||
| * | |||
| * When the user clicks on a month, pagination will be reset, but tags retained. Pagination retains all other | |||
| * parameters. | |||
| * | |||
| * @extends DatedUpdateHolderController<NewsHolder> | |||
There was a problem hiding this comment.
Suggested change
| * @extends DatedUpdateHolderController<NewsHolder> | |
| * @extends DatedUpdateHolderController<EventHolder> |
? I'm not sure if this is correct or not
There was a problem hiding this comment.
Oops! Yup good catch. That was a copy paste error.
Fixed.
GuySartorelli
force-pushed
the
pulls/3/add-generics
branch
from
ef8aa04 to
0f4ac01
Compare
emteknetnz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 and the corresponding silverstripe/cms PR for these generics to take effect.
Issue