-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Document making variants with different file extensions #441
DOC Document making variants with different file extensions #441
Conversation
6069172
to
8ec6d8a
Compare
8ec6d8a
to
bc37886
Compare
@michalkleiner Please stop suggesting rewording for content that I moved from one file to another. Changing that wording is not in scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads well. Mostly just minor stylistic suggestions and typo fixes.
I reviewed the change as a whole. In my opinion if there are changes/tweaks that make sense to do to improve the overall quality of docs while we are touching the area, especially when they can be simply accepted in bulk via Github UI, I don't see that as a bad thing. Feel free to reject those if it bothers you too much. |
I've made the changes that didn't require any thought, or which resolved potential confusion, or which were in scope. |
bc37886
to
7223e66
Compare
7223e66
to
8d6b727
Compare
8d6b727
to
0443770
Compare
Will hold off merging in case anything comes up in peer review on silverstripe/silverstripe-assets#585 (review) |
Description
This PR has two commits:
Please avoid recommending changes for content that I have simply lifted from one page and shifted to another.
Issues
Pull request checklist