Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add documentation about repository management #487

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Mar 26, 2024

Description

Add documentation about how we manage repositories.
For now it's all about branches but other repo management docs can be added as needed.

I decided to go with a nice broad scope for the page so we have somewhere to add anything else related to repo management in the future, rather than having a page that is only about branch protection rules.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

Comment on lines +11 to +34
### Naming convention

Branches with a single integer (e.g. `5`) represent either the next *major* release (if there have been no tagged releases for that release line yet) or the next *minor* release.

Branches with an integer, a dot, and another integer (e.g. `5.2`) represent either the *next patch release* for the current minor, or a patch release for a previous minor version.

> [!NOTE]
> Branches with any other naming strategy should not be the target of any pull requests. Only branches following this naming convention are included in merge-ups and are used as the base for new tagged releases.

For example, if we have the following tags:

```text
5.1.17
5.2.0
```

Then:

- `5.1` is the patch release branch for the previous minor version. High severity security fixes should target this branch.
- `5.2` is the next-patch release branch for the current minor version. Bugfixes should target this branch.
- `5` is the next-minor release branch. Enhancements should target this branch.
- `6` is the next-major release branch. Changes that break backwards compatibility should target this branch.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is outside of the scope of the issue - but makes sense to document here while I'm at it.

@GuySartorelli GuySartorelli force-pushed the pulls/5.2/repository-docs branch from a5205c8 to 02dbb32 Compare March 26, 2024 23:21
@GuySartorelli GuySartorelli marked this pull request as ready for review March 26, 2024 23:23
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@emteknetnz emteknetnz merged commit 45e8297 into silverstripe:5.2 Mar 27, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/5.2/repository-docs branch March 27, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants