NEW Pass in-memory-cache input for extra_jobs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1/in-memory-cache
branch
from
59903d8 to
0332303
Compare
emteknetnz
requested changes
Jul 11, 2024
job_creator.php
Outdated
| @@ -543,6 +549,9 @@ public function createJson(string $yml): string | |||
| $simpleMatrix = $this->parseBoolValue($value); | |||
| } else if (in_array($input, ['github_my_ref', 'github_repository', 'parent_branch'])) { | |||
| continue; | |||
| } else if ($input === 'phpunit_skip_suites') { | |||
| // value is a comma-separated string | |||
| $skipPhpunitSuites = array_map(fn($val) => trim($val), explode(',', $value)); | |||
There was a problem hiding this comment.
Suggested change
| $skipPhpunitSuites = array_map(fn($val) => trim($val), explode(',', $value)); | |
| $skipPhpunitSuites = array_map('trim', explode(',', $value)); |
emteknetnz
requested changes
Jul 11, 2024
job_creator.php
Outdated
| @@ -152,6 +152,7 @@ public function createJob(int $phpIndex, array $opts): array | |||
| 'endtoend_config' => '', | |||
| 'js' => false, | |||
| 'doclinting' => false, | |||
| 'install_inmemory_cache_exts' => false, | |||
There was a problem hiding this comment.
Suggested change
| 'install_inmemory_cache_exts' => false, | |
| 'install_in_memory_cache_exts' => false, |
job_creator.php
Outdated
Comment on lines
640
to
642
| if ($job['install_inmemory_cache_exts'] == 'true') { | ||
| $name[] = 'inmemorycache'; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ($job['install_inmemory_cache_exts'] == 'true') { | |
| $name[] = 'inmemorycache'; | |
| } | |
| if ($job['install_in_memory_cache_exts'] == 'true') { | |
| $name[] = 'inmemorycache'; | |
| } |
I had considered that but there's no tests for any of the extra_jobs stuff right now. If we want test coverage for extra_jobs we should do that as a separate card, and add coverage for it as a whole rather than just for this small part of it. |
GuySartorelli
force-pushed
the
pulls/1/in-memory-cache
branch
from
0332303 to
26c4c67
Compare
emteknetnz
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes along the new input for extra_jobs. See silverstripe/gha-ci#135
Issue