Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Include filename of script in predictable_random_int() #39

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 14, 2024

Issue #20

This will change every cron next time module standardiser is run. It's not worth doing now, makes sense to me to just update the crons next time we have something else to update at the same time to cut down on the number of PRs we need to worry about

@emteknetnz emteknetnz force-pushed the pulls/main/random-int branch 4 times, most recently from bd84b27 to d66089d Compare February 14, 2024 23:41
@emteknetnz emteknetnz force-pushed the pulls/main/random-int branch from d66089d to 7cb4fe3 Compare February 15, 2024 01:44
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Very good idea adding a test to it given our recent "oh no is that playing up?" scare.

@GuySartorelli GuySartorelli merged commit 7a6baed into silverstripe:main Feb 15, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/random-int branch February 15, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants