Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various problems (multiple commits) #64

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jun 18, 2024

Fixes various problems I found while running the standardiser:

  1. There was a syntax error using a heredoc instead of a nowdoc (${ was interpreted as being for string interpolation, though it should just be included as-is)
  2. New action was being added to a couple items that aren't supported (e.g. frameworktest), and wasn't being added to docs
  3. Processing was interrupted to tell me that frameworktest and a couple of other repos don't have a next-patch branch. That should just be a warning at the end, instead.

Issue

Comment on lines +227 to +232
// Report about any repos for which we couldn't find the right branch.
if (count($reposMissingBranch)) {
$reposString = implode("\n- ", $reposMissingBranch);
warning("Could not find branch to checkout for the following repos using --branch=$branchOption:\n- $reposString");
return Command::FAILURE;
}
Copy link
Member Author

@GuySartorelli GuySartorelli Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this at the end of execution (after all other output):

image

Used to be a single error for each one, which automatically halted the run. You'd have to then add the repo to the exclude list, run it again, and repeat the next time it fails, etc.

@emteknetnz emteknetnz merged commit 554915b into silverstripe:main Jun 18, 2024
1 check passed
@emteknetnz emteknetnz deleted the pulls/main/various-problems branch June 18, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants