Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add silverstripe/silverstripe-template-engine tests to test suite #75

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Nov 4, 2024

Adds the new module to a test suite in kitchen sink so it gets included in kitchen sink runs.

NOTE: The CI for this won't go green one of the other PRs that adds the dependency gets merged.

Issue

@GuySartorelli GuySartorelli changed the base branch from 5 to 6 November 4, 2024 03:45
@GuySartorelli GuySartorelli force-pushed the pulls/6/template-engine-move branch from 9d576cd to f43049b Compare November 4, 2024 03:45
@GuySartorelli GuySartorelli marked this pull request as draft November 4, 2024 03:45
@GuySartorelli GuySartorelli changed the title Pulls/6/template engine move MNT Add silverstripe/silverstripe-template-engine tests to test suite Nov 4, 2024
@GuySartorelli GuySartorelli marked this pull request as ready for review November 5, 2024 00:49
@emteknetnz emteknetnz merged commit 97538e4 into silverstripe:6 Nov 6, 2024
56 of 57 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/template-engine-move branch November 11, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants