API Standardise extension hooks #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/3/standardise-extension-hooks
branch
2 times, most recently
from
cb405cc to
9c0a446
Compare
GuySartorelli
commented
Aug 20, 2024
| $this->logInWithPermission('ADMIN'); | ||
| $this->logInWithPermission('CMS_ACCESS_CampaignAdmin'); |
There was a problem hiding this comment.
Having admin access results in an early return true in versioned canPublish() so our extension wasn't being called which resulted in incorrectly failing unit tests.
That's only just not become a thing because the path for public methods on extensions is different - it was being called "directly" (earlier than the versioned method) instead of being used as an extension hook.
GuySartorelli
force-pushed
the
pulls/3/standardise-extension-hooks
branch
from
9c0a446 to
575bc5b
Compare
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue