Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove silverstripe/campaign-admin integration support #1512

Merged
merged 1 commit into from
Nov 28, 2024
Merged

API Remove silverstripe/campaign-admin integration support #1512

merged 1 commit into from
Nov 28, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 20, 2024 •
edited
Loading

@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch 2 times, most recently from 5c4ccdc to 5aa270b Compare November 25, 2024 01:34
@emteknetnz emteknetnz mentioned this pull request Nov 25, 2024
Closed
15 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch 2 times, most recently from f4eadf4 to b8257b9 Compare November 26, 2024 03:03
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
GuySartorelli
GuySartorelli approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other code change PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch from b8257b9 to a6242c3 Compare November 27, 2024 01:12
@emteknetnz emteknetnz force-pushed the pulls/3/remove-support branch from a6242c3 to cce5b2f Compare November 27, 2024 22:07
@GuySartorelli GuySartorelli merged commit 7ada4e1 into silverstripe:3 Nov 28, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/remove-support branch November 28, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli