API Avoid reimplementing logic from ModalController #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Nov 26, 2024
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/3/modal-controller
branch
from
be68169 to
4fb0eac
Compare
GuySartorelli
force-pushed
the
pulls/3/modal-controller
branch
from
4fb0eac to
2a5c58b
Compare
emteknetnz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces duplicated code by calling methods on
ModalControllerinstead.Relies on changes in silverstripe/silverstripe-admin#1860
Issue
ModalControllersilverstripe-admin#1765