Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix behat test #1524

Merged
merged 1 commit into from
Dec 16, 2024
Merged

MNT Fix behat test #1524

merged 1 commit into from
Dec 16, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 16, 2024 •
edited
Loading

Issue silverstripe/.github#349

Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/12342589564/job/34442717488#step:12:777

And I should see the file named "folder1" in the gallery     # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::iShouldSeeTheGalleryItem()
  File named folder1 could not be found

@emteknetnz emteknetnz marked this pull request as ready for review December 16, 2024 01:52
@emteknetnz emteknetnz mentioned this pull request Dec 16, 2024
Open
GuySartorelli
GuySartorelli approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of adding seconds to the build without checking why it's needed but for now this is fine.
I might recommend we look at adding "and I wait until I see" for specific elements to replace fixed-time waiting in the new year.

@GuySartorelli GuySartorelli merged commit 3a87b87 into silverstripe:3.0 Dec 16, 2024
17 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.0/broken-builds branch December 16, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli