BUG Keep folder Name and Title in sync on update

[lukereative]

This was discovered while working to improve folder sorting, folders are sorted by Title but when you update their Name through the admin interface it would not update the Title and they would end up out of sync and quietly mess up alphabetical sorting.

Related but not dependant PR silverstripe/silverstripe-asset-admin#844

[robbieaverill]

Looks like a behavioural change which might not be intended. Can we have a unit test for this please? That might justify the change a bit more

[robbieaverill]

I'm kind of tempted to suggest that this is a feature, not a bug

[lukereative]

It doesn't seem like a feature, it seems to be an inconsistency because we already do it similarly on 'setTitle'

silverstripe-assets/src/Folder.php

Lines 127 to 133 in 63cabc7

	public function setTitle($title)
	{
	$this->setField('Title', $title);
	$this->setField('Name', $title);
	return $this;
	}

And it's causing an issue with asset admin, I'm going to add a unit test.

[robbieaverill]

Nice one!

[robbieaverill]

So you can still manually change the Title field because this is in a beforeWrite right?

[robbieaverill]

Nice branch name

[robbieaverill]

The code isn't immediately obvious why it works, but it does =D

Test case:

• Upload a file "dog.jpg". Title is set to "dog"
• Replace it with "cat.jpg". Title is set to "cat"
• Change the title to "my pets", save
• Replace file with "dogs.jpg". Title is not changed from "my pets"
• Replace file with "cats.jpg". Title is not changed from "my pets"

👍