Skip to content

Commit

Permalink
MNT Update unit test to handle HTML5Value
Browse files Browse the repository at this point in the history
  • Loading branch information
emteknetnz committed Dec 20, 2022
1 parent 0b6ee12 commit 4a5e22c
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion tests/php/Model/SiteTreeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
use SilverStripe\View\Shortcodes\EmbedShortcodeProvider;
use TractorCow\Fluent\Extension\FluentSiteTreeExtension;
use const RESOURCES_DIR;
use SilverStripe\View\Parsers\HTMLValue;
use SilverStripe\HTML5\HTML5Value;

class SiteTreeTest extends SapphireTest
{
Expand Down Expand Up @@ -2023,10 +2025,20 @@ public function testCMSEditLink()
*/
public function testSanitiseExtraMeta(string $extraMeta, string $expected, string $message): void
{
// If using HTML5Value then the 'somethingdodgy' test won't be converted to valid html
// However if using the default HTMLValue, then it will be converted to valid html
$isDodgyAndUsingHTML5 = strpos($expected, 'somethingdodgy') !== false &&
(HTMLValue::create() instanceof HTML5Value);
if ($isDodgyAndUsingHTML5) {
$this->expectException(ValidationException::class);
$this->expectExceptionMessage('Custom Meta Tags does not contain valid HTML');
}
$siteTree = new SiteTree();
$siteTree->ExtraMeta = $extraMeta;
$siteTree->write();
$this->assertSame($expected, $siteTree->ExtraMeta, $message);
if (!$isDodgyAndUsingHTML5) {
$this->assertSame($expected, $siteTree->ExtraMeta, $message);
}
}

public function provideSanitiseExtraMeta(): array
Expand Down

0 comments on commit 4a5e22c

Please sign in to comment.