API Update API to reflect changes in silverstripe/framework #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
GuySartorelli
force-pushed
the
pulls/6/new-description-config
branch
from
b432c54
to
1d6e135
Compare
GuySartorelli
force-pushed
the
pulls/6/new-description-config
branch
2 times, most recently
from
33e17ed
to
e73c467
Compare
GuySartorelli
force-pushed
the
pulls/6/new-description-config
branch
2 times, most recently
from
b252f6d
to
157c85e
Compare
GuySartorelli
changed the title
GuySartorelli
commented
Nov 20, 2024
Comment on lines
-32
to
-33
| color: $state-draft; | ||
| background-color: $state-modified-bg; |
There was a problem hiding this comment.
Rely on silverstripe/admin styling for colours
GuySartorelli
commented
Nov 20, 2024
Comment on lines
-212
to
+198
| {this.renderStatusBadge()} | ||
| {this.renderStatusFlagBadges()} |
There was a problem hiding this comment.
We're rendering potentially multiple badges now, so I've updated the logic to handle that and to pull the status flags from BaseElement.
GuySartorelli
commented
Nov 20, 2024
| @@ -205,6 +205,7 @@ public function apiReadElements(HTTPRequest $request): HTTPResponse | |||
| 'canPublish' => $element->canPublish(), | |||
| 'canUnpublish' => $element->canUnpublish(), | |||
| 'canCreate' => $element->canCreate(), | |||
| 'statusFlags' => $element->getStatusFlags(), | |||
There was a problem hiding this comment.
Pulls through status flags for use in javascript
GuySartorelli
force-pushed
the
pulls/6/new-description-config
branch
2 times, most recently
from
eff93d5
to
af06aea
Compare
GuySartorelli
force-pushed
the
pulls/6/new-description-config
branch
from
af06aea
to
26d094d
Compare
emteknetnz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces use of the overly-broadly named
descriptionconfiguration in favour of the newclass_descriptionconfig added in silverstripe/silverstripe-framework#11460 and usesi18n_classDescriptioninstead of custom i18n code.Also updates status flag rendering to render any flags in
getStatusFlags().Ends up looking something like this (custom flag added by overriding
getStatusFlags())Issue
SiteTreeinCMSMainsilverstripe-cms#2947