Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Correctly share cache between CLI and non-CLI #11146

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 16, 2024

Description

Fixes a bug where config can get out of sync between CLI and non-CLI contexts.

Requires symfony to release a fix for symfony/symfony#53962 on their end.
While there's no harm in merging this early in theory, we should hold off until they're resolved the underlying bug in case the resolution has flow-on effects.

Manual testing steps

Steps are mentioned in the linked issue.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Mar 14, 2024

Looks like the idea that APCu cache can be flushed by CLI is just fundamentally not a thing.
Some of this PR may still be useful (i.e. using PhpFilesAdapter for both CLI and non-CLI), but should be done from scratch.

@GuySartorelli GuySartorelli deleted the pulls/5/warm-apcu-cache branch March 14, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant