Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Ignore narrow no-break space in regex in tests #11291

Conversation

GuySartorelli
Copy link
Member

I ran framework's unit tests locally with MariaDB 11.4, and got some failures. The failures were a result of having U+202F instead of a regular space in the result. The tests I've updated don't really care what kind of space is used, so replacing the space with \h and allowing unicode matches resolves these problems.

Didn't see any repeats of this problem, so fingers crossed we don't see that in CI either once we make the change there.

Issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't replicate this issue locally running 11.4 on a vanilla 5.2 install

mysql> select @@version;
+------------------------+
| @@version              |
+------------------------+
| 11.4.2-MariaDB-ubu2404 |
+------------------------+

I'm not running DDEV, just a vanilla docker and docker-compose. Perhaps there's some config setting difference between our setups?

Regardless, doesn't seem like it's a good thing that the output is changing with a database upgrade, seems like a better solution might be to str_replace() out the unicode spaces with regular spaces?

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Jun 27, 2024

I can't replicate this issue locally running 11.4 on a vanilla 5.2 install

Huh. Must be something weird with my setup then.

@GuySartorelli GuySartorelli deleted the pulls/5.2/less-strict-regex branch June 27, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants