Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Do not require _config dir or _config.php for modules #11296

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 1, 2024

Issue #11254

I think it makes sense to target CMS 6 with this rather than CMS 5, as there's a small chance that classes that aren't currently being included are suddently unintentionally included

@emteknetnz emteknetnz changed the title NEW Do not require _config dir or _config.php for modules ENH Do not require _config dir or _config.php for modules Jul 1, 2024
@emteknetnz emteknetnz force-pushed the pulls/6/manifest-composer branch from 18a5a34 to 98dc238 Compare July 1, 2024 04:33
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit d96d852 into silverstripe:6 Jul 1, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/manifest-composer branch July 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants